Skip to content

goto-link regression test: Set the executable bit after copying #4112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2019
Merged

goto-link regression test: Set the executable bit after copying #4112

merged 1 commit into from
Feb 7, 2019

Conversation

tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented Feb 7, 2019 •
edited
Loading

CodeBuild/Windows regression tests suddenly had started to fail with:

Failed test: Fo 
bash: ../../../src/goto-cc/goto-link: Permission denied 
EXIT=126

It's not clear why this is newly necessary, but forcing the executable bit solves the problem.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

allredj
allredj reviewed Feb 7, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: c448a67).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100055009
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

allredj
allredj reviewed Feb 7, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 90ae73d).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100060019
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

@tautschnig
goto-link regression test: Set the executable bit after copying
d1c1092 
It seems that Cygwin loses the executable bit (which really is implemented via
ACLs) when copying a file. Just force it instead.
@tautschnig tautschnig changed the title [WIP] Debug Windows CI failure goto-link regression test: Set the executable bit after copying Feb 7, 2019
allredj
allredj reviewed Feb 7, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 2dd624d).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100063489
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

@tautschnig
Copy link
Collaborator Author

I'll not wait for the bot to confirm as there weren't any source changes, just (Windows-specific) build tooling. The earlier bot failures all referred to commits that I had force-pushed away.

@tautschnig tautschnig merged commit ccd97d4 into diffblue:develop Feb 7, 2019
@tautschnig tautschnig deleted the fix-windows-CI branch February 7, 2019 11:17
allredj
allredj reviewed Feb 7, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: d1c1092).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100067519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@peterschrammel peterschrammel peterschrammel approved these changes

Assignees
No one assigned
Labels
Build Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tautschnig @peterschrammel @allredj